[sigh] prevent crashes in fetch_profiles
when profiles have no bundle_id
#21758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This change is required for fastlane sigh, if the provisioning profiles for Apple needs to be recreated or fetched.
Shell command:
fastlane sigh --app_identifier $APP_ID --username $FASTLANE_USER --provisioning_name $PROVISIONINF_NAME --team_id $TEAM_ID --template_name "$TEMPLATE_NAME" --ignore_profiles_with_different_name --skip_certificate_verification
Error: identifier' for nil:NilClass (NoMethodError)
If a build pipeline is running the same shell / bash command for fastlane sigh multiple times, the error is happening sporadically.
Resolves #21238
Description
The change is to check if the profile.bundle_id is nil / null.
Testing Steps
Changes are tested within a forked repository. From this forked repository, the forked version for gem install was created, implemented in the pipeline and many builds are triggered and ran successfully in parallel using the above fastlane sigh command.